lostluck commented on a change in pull request #15946:
URL: https://github.com/apache/beam/pull/15946#discussion_r747719324
##########
File path: sdks/go/pkg/beam/core/metrics/store.go
##########
@@ -128,9 +128,11 @@ func (e Extractor) ExtractFrom(store *Store) error {
}
}
if e.MsecsInt64 != nil {
+ store.mu.Lock()
Review comment:
This isn't required, you're already acquiring locks up at the start of
the method. (the RLock & RUnlock since this only reads data, not writes to the
store) That's causing the deadlock failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
