katsiapis commented on a change in pull request #15969:
URL: https://github.com/apache/beam/pull/15969#discussion_r749588924
##########
File path: sdks/python/apache_beam/pipeline.py
##########
@@ -891,8 +891,10 @@ def visit_transform(self, transform_node):
if (isinstance(output.element_type,
typehints.TupleHint.TupleConstraint) and
len(output.element_type.tuple_types) == 2):
- output.requires_deterministic_key_coder = (
- deterministic_key_coders and transform_node.full_label)
+ if (pcoll.element_type.tuple_types[0] ==
Review comment:
Should this "if" become an "and" in the existing if above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
