lostluck commented on pull request #15939: URL: https://github.com/apache/beam/pull/15939#issuecomment-969596882
> For some reason I would have moved the `if elm.GetIsLast()` to beyond the existing `select case` but can see that we still want to delete from the cache and that doesn't play nicely with the existing code layout. I can't see any reason it shouldn't work, but I don't want to re-reason through the cache behavior at the moment so I'm hesitant to move it. I feel the clarity of distinct "this is the last element" handling supersedes deduplicating. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
