mosche commented on pull request #15955:
URL: https://github.com/apache/beam/pull/15955#issuecomment-971364866


   Actually, this is more complicated (broken?) than I thought. Closing the PR 
for now.
   Per JVM a producer is shared among all `KinesisWriterFn`s. Sharing producers 
absolutely makes sense, nevertheless this still leaks. Also, if the static 
instance is reused producer properties might be silently dropped without notice.
   ```
         private static transient IKinesisProducer producer;
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to