slavachernyak commented on a change in pull request #15998:
URL: https://github.com/apache/beam/pull/15998#discussion_r751441288
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StreamingWriteTables.java
##########
@@ -339,14 +402,17 @@ public WriteResult
expand(PCollection<KV<TableDestination, ElementT>> input) {
input
.apply("ShardTableWrites", ParDo.of(new
GenerateShardedTable<>(numShards)))
.setCoder(KvCoder.of(ShardedKeyCoder.of(StringUtf8Coder.of()),
elementCoder))
- .apply("TagWithUniqueIds", ParDo.of(new TagWithUniqueIds<>()))
+ .apply("TagWithUniqueIds", ParDo.of(new
TagWithUniqueIds<>(toUniqueId)))
.setCoder(
KvCoder.of(
ShardedKeyCoder.of(StringUtf8Coder.of()),
TableRowInfoCoder.of(elementCoder)));
+ if (!skipReshuffle) {
+ shardedTagged = shardedTagged.apply(Reshuffle.of());
Review comment:
Changed as discussed to withDeterministicRecordIdFn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
