ryanthompson591 commented on a change in pull request #15472:
URL: https://github.com/apache/beam/pull/15472#discussion_r751571150
##########
File path: sdks/python/apache_beam/coders/coders_test_common.py
##########
@@ -667,11 +667,13 @@ def test_state_backed_iterable_coder(self):
state = {}
def iterable_state_write(values, element_coder_impl):
+ global state
Review comment:
I think we need more thorough E2E tests. This current PR only has unit
tests for cloudpickler (the new thing introduces) to make sure that the
defaults work.
I would like some more complete/complex tests, but would love for them to be
in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
