benWize commented on pull request #15742: URL: https://github.com/apache/beam/pull/15742#issuecomment-973042442
> I looked this over, but I still haven't gotten through everything. I would like to actually review all the changes closely since these have the potential to break users. But that's going to make it really hard to get this in... by the time I'm done looking it all over there will surely be merge conflicts. I think we should try to break this up a little bit to avoid merge conflicts, and make it easier for multiple people to review. > > I just proposed #16010 which adds a configuration variable `suppressUnusedVariable: true` to every build.gradle. If you're ok with it, we could merge that change, and then you'd be able to send a few PRs that enable the unused variable warning for a few related packages at once (e.g. one for all SQL extensions, one for all IOs, one for all runners). We should be able to distribute the reviews for those PRs, and get them merged quick enough to avoid conflicts. What do you think? I am ok with breaking up this PR into smaller ones. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
