benWize commented on pull request #15968: URL: https://github.com/apache/beam/pull/15968#issuecomment-973094663
> thanks a lot for working on this. I took a quick look and left a few comments. high-level note: it seems that we rely on files like examples_test.py to exercise examples in files like example.py. Ideally the tests should exercise the same pipeline as the example, so that if an example changes, the test will run the updated version. Thank you for your quick review, I think maybe we can move forward with the changes related to the new jobs in this PR, to avoid several loops of changes -> seed job -> runner jobs, and check individual tests for each example/runner in another PR, what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
