pabloem commented on a change in pull request #16026:
URL: https://github.com/apache/beam/pull/16026#discussion_r755340821
##########
File path: playground/backend/internal/code_processing/code_processing.go
##########
@@ -110,20 +102,9 @@ func Process(ctx context.Context, cacheService
cache.Cache, lc *fs_tool.LifeCycl
// run
logger.Infof("%s: Run() ...\n", pipelineId)
runCmd := executor.Run(ctxWithTimeout)
-
var runError bytes.Buffer
- runOutput := &streaming.RunOutputWriter{Ctx: ctxWithTimeout,
CacheService: cacheService, PipelineId: pipelineId}
- runCmd.Stderr = &runError
- runCmd.Stdout = runOutput
- go func(cmd *exec.Cmd, successChannel chan bool, errChannel chan error,
dataChannel chan interface{}) {
- err := cmd.Run()
- if err != nil {
- errChannel <- err
- successChannel <- false
- } else {
- successChannel <- true
- }
- }(runCmd, successChannel, errorChannel, dataChannel)
+ runOutput := streaming.RunOutputWriter{Ctx: ctxWithTimeout,
CacheService: cacheService, PipelineId: pipelineId}
Review comment:
some users may want to read stderr in the frontend as well as stdout, so
maybe it makes sense to write that to the cache as well.
if I remember correctly, LOG data is weitten to stderr, while only
System.out.println-type data will be sent to stdout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
