ibzib commented on a change in pull request #15375:
URL: https://github.com/apache/beam/pull/15375#discussion_r756308977
##########
File path:
sdks/java/extensions/ml/src/test/java/org/apache/beam/sdk/extensions/ml/RecommendationAICatalogItemIT.java
##########
@@ -41,14 +46,17 @@
@RunWith(JUnit4.class)
public class RecommendationAICatalogItemIT {
- @Rule public TestPipeline testPipeline = TestPipeline.create();
+ @Rule public static TestPipeline testPipeline = TestPipeline.create();
+ static String projectId =
testPipeline.getOptions().as(GcpOptions.class).getProject();
Review comment:
```suggestion
private static String projectId =
testPipeline.getOptions().as(GcpOptions.class).getProject();
```
##########
File path:
sdks/java/extensions/ml/src/test/java/org/apache/beam/sdk/extensions/ml/RecommendationAICatalogItemIT.java
##########
@@ -92,6 +98,23 @@ public void importCatalogItems() {
testPipeline.run().waitUntilFinish();
}
+ @AfterClass
+ public static void tearDownAfterClass() throws Exception {
+ try (CatalogServiceClient catalogServiceClient =
CatalogServiceClient.create()) {
+ String parent = CatalogName.of("apache-beam-testing", "global",
"default_catalog").toString();
Review comment:
```suggestion
String parent = CatalogName.of(projectId, "global",
"default_catalog").toString();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
