mosche commented on a change in pull request #15955:
URL: https://github.com/apache/beam/pull/15955#discussion_r758477064
##########
File path:
sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/KinesisIO.java
##########
@@ -917,30 +971,6 @@ public void startBundle() {
putFutures = Collections.synchronizedList(new ArrayList<>());
/** Keep only the first {@link MAX_NUM_FAILURES} occurred exceptions */
failures = new LinkedBlockingDeque<>(MAX_NUM_FAILURES);
- initKinesisProducer();
- }
-
- private synchronized void initKinesisProducer() {
- // Init producer config
- Properties props = spec.getProducerProperties();
- if (props == null) {
- props = new Properties();
- }
- KinesisProducerConfiguration config =
KinesisProducerConfiguration.fromProperties(props);
- // Fix to avoid the following message "WARNING: Exception during
updateCredentials" during
- // producer.destroy() call. More details can be found in this thread:
- // https://github.com/awslabs/amazon-kinesis-producer/issues/10
- config.setCredentialsRefreshDelay(100);
Review comment:
Sorry, seems like the comment on this got lost.
The workaround here is long obsolete, and fixed by
https://github.com/awslabs/amazon-kinesis-producer/issues/34#issuecomment-388440049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
