TheNeuralBit commented on a change in pull request #16034:
URL: https://github.com/apache/beam/pull/16034#discussion_r758639731
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamCalcRel.java
##########
@@ -244,6 +244,7 @@ private RowCoder getErrorRowCoder(PCollection<Row>
upstream, InputGetterImpl inp
private final boolean verifyRowValues;
private final List<String> jarPaths;
+ @SuppressWarnings("unused")
Review comment:
This looks like another place we should add TODO(BEAM-13271) (In the
next errorprone releasethere will be a way to indicate that annotations like
FieldAccess are used reflectively)
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamCalcRel.java
##########
@@ -244,6 +244,7 @@ private RowCoder getErrorRowCoder(PCollection<Row>
upstream, InputGetterImpl inp
private final boolean verifyRowValues;
private final List<String> jarPaths;
+ @SuppressWarnings("unused")
Review comment:
This looks like another place we should add TODO(BEAM-13271) (In the
next errorprone release there will be a way to indicate that annotations like
FieldAccess are used reflectively)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
