TheNeuralBit commented on a change in pull request #16093:
URL: https://github.com/apache/beam/pull/16093#discussion_r760313118
##########
File path: sdks/python/apache_beam/dataframe/frame_base.py
##########
@@ -160,8 +160,10 @@ def _proxy_method(
restrictions=None,
inplace=False,
base=None,
- requires_partition_by=partitionings.Singleton(),
- preserves_partition_by=partitionings.Arbitrary()):
+ *,
+ requires_partition_by, # type: partitionings.Partitioning
+ preserves_partition_by, # type: partitionings.Partitioning
Review comment:
should we prefer PEP 484 type hints now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
