ryanthompson591 commented on a change in pull request #16056:
URL: https://github.com/apache/beam/pull/16056#discussion_r761306165
##########
File path: sdks/python/container/Dockerfile
##########
@@ -69,7 +69,7 @@ RUN ccache --set-config=sloppiness=file_macro && ccache
--set-config=hash_dir=fa
####
COPY target/apache-beam.tar.gz /opt/apache/beam/tars/
RUN pip install --no-deps -v /opt/apache/beam/tars/apache-beam.tar.gz[gcp]
-RUN pip check
+RUN pip check || (echo "Container does not include required Beam dependencies
or has conflicting dependencies. If Beam dependencies have changed, you need to
regenerate base_image_requirements.txt files." && exit 1)
Review comment:
Is it worth having a link to how to do this?
##########
File path: sdks/python/container/run_generate_requirements.sh
##########
@@ -33,13 +33,25 @@
if [[ $# != 2 ]]; then
printf "Usage: \n$> ./sdks/python/container/run_generate_requirements.sh
<python_version> <sdk_tarball>"
printf "\n\tpython_version: [required] Python version to generate
dependencies for."
- printf " Use 3.7 for Python3.7, 3.8 for Python3.8 etc."
+ printf "\n\tUse 3.7 for Python3.7, 3.8 for Python3.8 etc.\n"
Review comment:
How about:
example usage: ./run_generate_requirements 3.7
Where 3.7 is the version of python.
I'm also wondering about this script. Will it be the case that you would run
this to generate requirements for a specific version of python, or would it be
more common to just want to generate all requirements?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
