daria-malkova commented on a change in pull request #16140:
URL: https://github.com/apache/beam/pull/16140#discussion_r763062547
##########
File path: playground/infrastructure/ci_cd.py
##########
@@ -16,37 +16,76 @@
"""
Module implements CI/CD steps for Beam Playground examples
"""
-
+import argparse
import asyncio
import os
+from typing import List, Literal
+import config
+from api.v1.api_pb2 import Sdk
from cd_helper import CDHelper
from ci_helper import CIHelper
-from helper import find_examples, get_supported_categories
+from helper import find_examples, get_supported_categories, Example
from logger import setup_logger
+parser = argparse.ArgumentParser(
+ description="CI/CD Steps for Playground objects")
+parser.add_argument(
+ "--step",
+ dest="step",
+ required=True,
+ help="CI step to verify all beam examples/tests/katas. CD step to save all
"
+ "beam examples/tests/katas and their outputs on the GCS",
+ choices=["CI", "CD"])
Review comment:
Can't we do it like below: config.Config.SUPPORTED_SDK?
Please move available steps to the config
##########
File path: playground/infrastructure/ci_cd.py
##########
@@ -16,37 +16,76 @@
"""
Module implements CI/CD steps for Beam Playground examples
"""
-
+import argparse
Review comment:
I don't see it in requirements, shouldn't this be added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
