roger-mike commented on a change in pull request #16027:
URL: https://github.com/apache/beam/pull/16027#discussion_r763470689
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -3441,6 +3460,18 @@ def value_counts(self, subset=None, sort=False,
normalize=False,
else:
return result
+ @frame_base.with_docs_from(pd.DataFrame)
+ @frame_base.args_to_kwargs(pd.DataFrame)
+ @frame_base.populate_defaults(pd.DataFrame)
+ def compare(self, other, **kwargs):
Review comment:
Thanks for your comments @TheNeuralBit. I handled the (`align_axis=1`,
`keep_shape=False`) case as you suggest. The other cases work just fine. I also
disabled proxy check for the (`align_axis=0`, `keep_shape=False`) test case
since its result also depends on the input data. Let me know what you think 👍 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
