ilya-kozyrev commented on a change in pull request #16151:
URL: https://github.com/apache/beam/pull/16151#discussion_r764028690
##########
File path: playground/backend/containers/python/Dockerfile
##########
@@ -47,5 +47,9 @@ ENV BEAM_SDK="SDK_PYTHON"
COPY --from=build /go/bin/server_python_backend /opt/playground/backend/
COPY --from=build /go/src/playground/backend/configs
/opt/playground/backend/configs/
+# Install Python Katas Utils
+COPY katas/log_elements.py /go/src/katas/
+ENV PYTHONPATH="/go/src/katas"
Review comment:
Could we add a new folder to the python path instead of overriding it?
${PYTHONPATH}:/go/src/katas
##########
File path: playground/backend/containers/java/Dockerfile
##########
@@ -69,5 +69,11 @@ RUN wget
https://repo1.maven.org/maven2/org/hamcrest/hamcrest-all/$HAMCREST_VERS
# Install JUnit
RUN wget
https://repo1.maven.org/maven2/junit/junit/$JUNIT_VERSION/junit-$JUNIT_VERSION.jar
&&\
mv junit-$JUNIT_VERSION.jar /opt/apache/beam/jars/junit.jar
+# Install Java Katas Utils
+COPY katas /go/src/katas
+WORKDIR /go/src/katas
Review comment:
do we need to switch workdir for future commands? or we can add cd
/go/src/katas && to line 75?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
