ilya-kozyrev commented on a change in pull request #16127:
URL: https://github.com/apache/beam/pull/16127#discussion_r764093061
##########
File path: playground/backend/internal/executors/executor.go
##########
@@ -102,7 +104,9 @@ func (ex *Executor) Compile(ctx context.Context) *exec.Cmd {
// Returns Cmd instance
func (ex *Executor) Run(ctx context.Context) *exec.Cmd {
args := append(ex.runArgs.commandArgs, ex.runArgs.fileName)
- cmd := exec.CommandContext(ctx, ex.runArgs.commandName, args...)
+ argsWithOptions := append(args, ex.runArgs.pipelineOptions)
+ argsWithOptions = utils.RemoveEmptyValue(argsWithOptions)
Review comment:
it might come from the user side, i.e. --option1 option (2
whitespaces) and that valid command line way, however when we split to go cmd
we should remove extra spaces :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
