ibzib commented on pull request #16113: URL: https://github.com/apache/beam/pull/16113#issuecomment-988248806
> I left a bunch of comments, I don't think this works as is? You've used the TupleTag key where you should use the PCollection. The assumption is that each PCollection's self-identifying TupleTag is unique. But I agree using PCollection is better. TupleTags get kind of confusing because it is hard to distinguish which ones are globally unique and which ones are only local. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
