TheNeuralBit commented on a change in pull request #16142:
URL: https://github.com/apache/beam/pull/16142#discussion_r764382704
##########
File path: sdks/python/apache_beam/ml/gcp/cloud_dlp.py
##########
@@ -213,7 +213,7 @@ def setup(self):
self.client = dlp_v2.DlpServiceClient()
self.params = {
'timeout': self.timeout,
- "parent": self.client.project_path(self.project)
+ "parent": self.client.common_project_path(self.project)
Review comment:
This is due to a backwards-incompatible change in google-cloud-dlp
client library? Should we report it upstream?
##########
File path: sdks/python/setup.py
##########
@@ -195,7 +195,7 @@ def get_version():
'google-cloud-spanner>=1.13.0,<2',
'grpcio-gcp>=0.2.2,<1',
# GCP Packages required by ML functionality
- 'google-cloud-dlp>=0.12.0,<4',
+ 'google-cloud-dlp>=3.3.1,<4',
Review comment:
Consider re-running `./gradlew
:sdks:python:generatePythonRequirementsAll` for this (potentially in a
follow-up if you'd rather get tests green now). CC: @tvalentyn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
