TheNeuralBit commented on a change in pull request #16037:
URL: https://github.com/apache/beam/pull/16037#discussion_r760535645
##########
File path:
examples/java/src/main/java/org/apache/beam/examples/snippets/Snippets.java
##########
@@ -118,7 +118,8 @@
/** Code snippets used in webdocs. */
@SuppressWarnings({
"rawtypes", // TODO(https://issues.apache.org/jira/browse/BEAM-10556)
- "nullness" // TODO(https://issues.apache.org/jira/browse/BEAM-10402)
+ "nullness", // TODO(https://issues.apache.org/jira/browse/BEAM-10402)
+ "unused"
Review comment:
```suggestion
"unused" // TODO(BEAM-13271): Remove when new version of errorprone is
released (2.11.0)
```
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/FinalizeBundleHandler.java
##########
@@ -65,45 +59,13 @@ public static CallbackRegistration create(
public abstract BundleFinalizer.Callback getCallback();
}
- private static final Logger LOG =
LoggerFactory.getLogger(FinalizeBundleHandler.class);
private final ConcurrentMap<String, Collection<CallbackRegistration>>
bundleFinalizationCallbacks;
private final PriorityQueue<TimestampedValue<String>> cleanUpQueue;
- private final Future<Void> cleanUpResult;
- public FinalizeBundleHandler(ExecutorService executorService) {
+ public FinalizeBundleHandler() {
this.bundleFinalizationCallbacks = new ConcurrentHashMap<>();
this.cleanUpQueue =
new PriorityQueue<>(11,
Comparator.comparing(TimestampedValue::getTimestamp));
- this.cleanUpResult =
Review comment:
Should we be inspecting `cleanUpResult` at some point to make sure it
worked?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
