AydarZaynutdinov commented on a change in pull request #16138:
URL: https://github.com/apache/beam/pull/16138#discussion_r765806403
##########
File path: playground/backend/containers/go/Dockerfile
##########
@@ -56,6 +56,4 @@ ENV BEAM_SDK="SDK_GO"
## Copy build result
COPY src/configs /opt/playground/backend/configs/
-ENTRYPOINT ["/opt/playground/backend/server_go_backend"]
-
-
+ENTRYPOINT ["/opt/playground/backend/server_go_backend"]
Review comment:
add an empty string.
##########
File path: playground/backend/internal/code_processing/code_processing.go
##########
@@ -88,14 +88,20 @@ func Process(ctx context.Context, cacheService cache.Cache,
lc *fs_tool.LifeCycl
_ = processError(ctxWithTimeout, errorChannel, pipelineId,
cacheService, "Validate", pb.Status_STATUS_VALIDATION_ERROR)
return
}
+ // Check if unit test
+ isUnitTest := false
+ valResult, ok :=
validationResults.Load(validators.UnitTestValidatorName)
+ if ok && valResult.(bool) {
+ isUnitTest = true
+ }
Review comment:
Maybe wrap it like a separate method?
##########
File path: playground/backend/internal/preparators/go_preparators.go
##########
@@ -17,31 +17,51 @@ package preparators
import (
"errors"
+ "fmt"
"os/exec"
"path/filepath"
+ "strings"
)
const (
- nameBinGo = "go"
- fmtArgs = "fmt"
+ goName = "go"
Review comment:
maybe `goFileExtension` instead of `goName`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
