lostluck commented on pull request #16163:
URL: https://github.com/apache/beam/pull/16163#issuecomment-990435389
Yup, you've got it right.
1. We don't currently run any of the Go examples in any sort of task with
gradle. But I have at least built and run most of them against dataflow
recently, so they should at least be that complete so far.
As a rule, no Go user will ever use Gradle to run the examples, they'd pull
the go package using the standard go tools, and execute them that way. Unless a
gradle task makes your job easier, we shouldn't wrap them like that.
2. That task probably does only build it, and is also likely out of date.
First time I've seen it. Feel free to remove/improve it. Probably remove.
3. While in my opinion, yes examples should be built with their own
integration tests, they're not currently built like that. Wordcount tends to
get duplicated because it's WordCount. In an ideal world, I'd have time to
refactor the lot of them, so they'd see exercise regularly, but would
technically have a different start points.
The script would likely be re-using the integration test script, but adding
the relevant Examples directories, building with the go tools. So each example
would also demonstrate *how* to test that example, from the Go side, rather
than have all the configuration elsewhere.
Everything except for the BiqQuery using examples should probably be fine to
run periodically. The BQ ones don't automatically set up tables for their
writes, so would require additional work first.
Now, if you'd like to work with me on that, I'd be delighted to help you!
However, I'm out between December 13th -20th (but will be available the
20th-22nd and 27th -29th). I should be able to demonstrate with one of the
example PRs tomorrow, if you'd like to help with the refactor over the next
week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
