KhaninArtur commented on a change in pull request #16172:
URL: https://github.com/apache/beam/pull/16172#discussion_r767629071
##########
File path: playground/backend/internal/validators/java_validators_test.go
##########
@@ -63,14 +62,67 @@ func TestCheckIsUnitTests(t *testing.T) {
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
- got, err := CheckIsUnitTestJava(tt.args.args...)
+ got, err := checkIsUnitTestJava(tt.args.args...)
+ if (err != nil) != tt.wantErr {
+ t.Errorf("checkIsUnitTestJava error = %v,
wantErr %v", err, tt.wantErr)
+ return
+ }
+ if got != tt.want {
+ t.Errorf("checkIsUnitTestJava got = %v, want
%v", got, tt.want)
+ }
+ })
+ }
+}
+
+func TestCheckIsKataJava(t *testing.T) {
+ testValidatorArgs := getValidatorsArgs(javaUnitTestFilePath,
javaUnitTestPattern)
+ validatorArgs := getValidatorsArgs(javaCodePath, javaUnitTestPattern)
Review comment:
Shouldn't there be `javaKataFilePath` instead of `javaUnitTestFilePath `
and `javaKatasPattern` instead of `javaUnitTestPattern`?
##########
File path: playground/backend/internal/validators/validator.go
##########
@@ -15,7 +15,10 @@
package validators
-const UnitTestValidatorName = "UnitTest"
+const (
+ UnitTestValidatorName = "UnitTest"
+ KatasValidatorName = "Check if the pipeline is katas"
Review comment:
Shouldn't `KatasValidatorName` equal just `"Katas"`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
