fernando-wizeline commented on pull request #16201: URL: https://github.com/apache/beam/pull/16201#issuecomment-992740418
> > > > LGTM How can we test this? > > > > > > > > > wiki has instructions ([cwiki.apache.org/confluence/display/BEAM/Community+Metrics#CommunityMetrics-UpdatingandDeploying](https://cwiki.apache.org/confluence/display/BEAM/Community+Metrics#CommunityMetrics-UpdatingandDeploying)) but I have not tried those. Assuming that this would be "fine" because it is a patch version change. > > > If anyone has an existing local setup I would appreciate if you can test it. I would take me a while to go over the local testing instructions. > > > I was hoping that the CommunityMetrics precommit will have sufficient tests but it does not seem to be the case. > > > > > > Hi @aaltay! It shouldn't break anything since it is a minor version update. I don't have bandwidth to test today, but maybe during the week I can test using the docker image which I used a few weeks ago to test the version change from 6 to 8 > > Thank you @fernando-wizeline. I would appreciate that very much. If you think that this would be safe, we can merge it and if it breaks anything roll it back. Don't mention it @aaltay! Glad I can help. By looking at the release notes, I'd say it is safe to upgrade. If we have to rollback I can take a look later in the week to pinpoint the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
