iemejia commented on a change in pull request #16191:
URL: https://github.com/apache/beam/pull/16191#discussion_r768191685



##########
File path: sdks/java/io/hcatalog/build.gradle
##########
@@ -43,7 +43,7 @@ test {
 
 configurations.testRuntimeClasspath {
   resolutionStrategy {
-    def log4j_version = "2.8.2"
+    def log4j_version = "2.15.0"

Review comment:
       If we want to force the same version everywhere maybe it is better to 
remove the full ` configurations.testRuntimeClasspath` block (to avoid versions 
divergence in the future).
   
   I had to explicitly pin an older version to avoid issues with the HCatalog 
tests if I remember correctly. If the full build passes with the updated 
version  I suppose it should be ok to go since log4j is mostly a 
transitive/runtime dependency.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to