mosche commented on a change in pull request #15931:
URL: https://github.com/apache/beam/pull/15931#discussion_r768427938
##########
File path: sdks/python/apache_beam/io/aws/clients/s3/boto3_client.py
##########
@@ -67,6 +69,11 @@ def __init__(self, options):
aws_secret_access_key=secret_access_key,
aws_session_token=session_token)
+ self._download_request = None
Review comment:
The following lines add some local mutable state to the client. I'm not
familiar with the Python SDK unfortunately, so not sure if this is legitimate.
In any case, I'd suggest to document this in the pydocs of the client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
