daria-malkova commented on a change in pull request #16198:
URL: https://github.com/apache/beam/pull/16198#discussion_r768530246
##########
File path: playground/backend/internal/code_processing/code_processing_test.go
##########
@@ -645,3 +647,184 @@ func Test_getRunOrTestCmd(t *testing.T) {
})
}
}
+
+func setupBenchmarks(sdk pb.Sdk) {
+ err := os.MkdirAll(configFolder, fs.ModePerm)
+ if err != nil {
+ panic(err)
+ }
+ filePath := filepath.Join(configFolder, sdk.String()+".json")
+ switch sdk {
+ case pb.Sdk_SDK_JAVA:
+ err = os.WriteFile(filePath, []byte(javaConfig), 0600)
Review comment:
Just a suggestion - you cold create map[SDK, config] instead of
switch-case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
