lukecwik commented on pull request #15549: URL: https://github.com/apache/beam/pull/15549#issuecomment-996115201
@aaltay This is not a high priority for me. It would be best if someone else had the cycles. I took a quick look and its great that we aren't copying the code for the restriction tracker. One sticking point is that the PR still doesn't address the usage of dbSize() which isn't the same as table size and I haven't been thorough on the tests. For example, we should have a case where the table size is large and the dbSize is small. We should also verify that the results we get when reading is a superset of the original table when the table is being continuously added to and similarly we should start with a large table and then remove most of the items by starting with a large set of numbers and then remove everything except for numbers that divide by 7 ensuring that the numbers that are read match all the expected numbers that wouldn't have been removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
