TheNeuralBit commented on a change in pull request #16262:
URL: https://github.com/apache/beam/pull/16262#discussion_r770957630
##########
File path:
sdks/java/io/xml/src/test/java/org/apache/beam/sdk/io/xml/XmlSourceTest.java
##########
@@ -540,10 +540,8 @@ public void
testReadXMLInvalidRecordClassWithCustomEventHandler() throws IOExcep
exception.expectMessage("MyCustomValidationEventHandler failure mesage");
try (Reader<WrongTrainType> reader = source.createReader(null)) {
- List<WrongTrainType> results = new ArrayList<>();
for (boolean available = reader.start(); available; available =
reader.advance()) {
- WrongTrainType train = reader.getCurrent();
- results.add(train);
Review comment:
This should probably make an assertion about results instead of removing
it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
