AydarZaynutdinov commented on a change in pull request #16273:
URL: https://github.com/apache/beam/pull/16273#discussion_r771437886
##########
File path: playground/backend/internal/environment/environment_service.go
##########
@@ -173,9 +174,13 @@ func createExecutorConfig(apacheBeamSdk pb.Sdk, configPath
string) (*ExecutorCon
}
switch apacheBeamSdk {
case pb.Sdk_SDK_JAVA:
- executorConfig.CompileArgs = append(executorConfig.CompileArgs,
getEnv(beamPathKey, defaultBeamJarsPath))
- executorConfig.RunArgs[1] = fmt.Sprintf("%s%s",
executorConfig.RunArgs[1], getEnv(beamPathKey, defaultBeamJarsPath))
- executorConfig.TestArgs[1] = fmt.Sprintf("%s%s",
executorConfig.TestArgs[1], getEnv(beamPathKey, defaultBeamJarsPath))
+ args, err := concatBeamJarsToString()
+ if err != nil {
+ return nil, err
Review comment:
Need to add some log here or in `concatBeamJarsToString()` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
