AydarZaynutdinov commented on a change in pull request #16278:
URL: https://github.com/apache/beam/pull/16278#discussion_r772254817
##########
File path: playground/backend/cmd/server/controller.go
##########
@@ -74,6 +74,9 @@ func (controller *playgroundController) RunCode(ctx
context.Context, info *pb.Ru
if err = utils.SetToCache(ctx, controller.cacheService, pipelineId,
cache.LogsIndex, 0); err != nil {
return nil, errors.InternalError("Run code()", "Error during
set value to cache: %s", err.Error())
}
+ if err = utils.SetToCache(ctx, controller.cacheService, pipelineId,
cache.Canceled, false); err != nil {
+ return nil, errors.InternalError("Run code()", "Error during
set cancel flag to cache as a false")
Review comment:
add `code_processing.DeleteFolders(pipelineId, lc)`
##########
File path: playground/backend/internal/code_processing/code_processing.go
##########
@@ -336,12 +336,13 @@ func cancelCheck(ctx context.Context, pipelineId
uuid.UUID, cancelChannel chan b
case <-ticker.C:
cancel, err := cacheService.GetValue(ctx, pipelineId,
cache.Canceled)
if err != nil {
- continue
+ logger.Errorf("%s: Process: cache.GetValue:
error: %s", cancel, err.Error())
}
if cancel.(bool) {
cancelChannel <- true
+ return
}
- return
+ continue
Review comment:
it seems that there is no need to use `continue` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
