youngoli commented on a change in pull request #16228:
URL: https://github.com/apache/beam/pull/16228#discussion_r772594833
##########
File path: sdks/go/pkg/beam/core/runtime/xlangx/expansionx/download.go
##########
@@ -58,6 +58,10 @@ func GetBeamJar(gradleTarget, version string) (string,
error) {
}
func (j *jarGetter) getJar(gradleTarget, version string) (string, error) {
+ if strings.Contains(version, ".dev") {
Review comment:
It seems reasonable to leave as-is if it's functionally equivalent to
the Python behavior. And checking the local cache first should mean that users
will be able to use local jars they've already built pretty easily. So I'll
approve it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
