dpcollins-google commented on a change in pull request #16307:
URL: https://github.com/apache/beam/pull/16307#discussion_r773244883
##########
File path: sdks/java/extensions/ml/build.gradle
##########
@@ -58,7 +58,8 @@ dependencies {
testImplementation 'com.google.cloud:google-cloud-recommendations-ai:0.3.7'
testImplementation 'com.google.cloud:google-cloud-video-intelligence:1.2.0'
testImplementation 'com.google.cloud:google-cloud-dlp:1.1.4'
- testImplementation project(path:
":sdks:java:extensions:google-cloud-platform-core", configuration:
"testRuntime")
+ testImplementation
project(":sdks:java:extensions:google-cloud-platform-core")
+ testImplementation project(path:
":sdks:java:extensions:google-cloud-platform-core", configuration:
"testRuntimeMigration")
Review comment:
remove this line, not needed?
##########
File path: sdks/java/extensions/sql/build.gradle
##########
@@ -91,9 +91,10 @@ dependencies {
testImplementation library.java.quickcheck_core
testImplementation library.java.testcontainers_kafka
testImplementation library.java.google_cloud_bigtable_emulator
- testImplementation project(path: ":sdks:java:io:mongodb", configuration:
"testRuntime")
- testImplementation project(path: ":sdks:java:io:thrift", configuration:
"testRuntime")
- testImplementation project(path: ":sdks:java:extensions:protobuf",
configuration: "testRuntime")
+ testImplementation project(path: ":sdks:java:io:mongodb", configuration:
"testRuntimeMigration")
+ testImplementation project(":sdks:java:io:thrift")
+ testImplementation project(path: ":sdks:java:io:thrift", configuration:
"testRuntimeMigration")
Review comment:
ditto
##########
File path: sdks/java/extensions/sql/jdbc/build.gradle
##########
@@ -37,7 +37,8 @@ dependencies {
implementation "sqlline:sqlline:1.4.0"
implementation library.java.vendored_guava_26_0_jre
implementation library.java.vendored_calcite_1_28_0
- testImplementation project(path: ":sdks:java:io:google-cloud-platform",
configuration: "testRuntime")
+ testImplementation project(":sdks:java:io:google-cloud-platform")
+ testImplementation project(path: ":sdks:java:io:google-cloud-platform",
configuration: "testRuntimeMigration")
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
