benWize commented on pull request #16253:
URL: https://github.com/apache/beam/pull/16253#issuecomment-999945920


   > I think neither option is ideal really. The best outcome would be test 
marked as passing or unstable, github UI showing passing, all tests results 
being available. I do not know if that is possible.
   
   Thanks, @aaltay, I tried with this plugin 
https://plugins.jenkins.io/flaky-test-handler/ in my local Jenkins setup, and 
with that plugin and this config 
https://github.com/apache/beam/blob/6d4af1cc8024e0f86d77fbcc66bf93030633f3d1/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L410
 the flaky tests were marked as passing, with a label: "flaked with N 
failures". Also, all tests results are available, and the global status of the 
job is marked as a success, so the GitHub UI is expected to show the check as 
passing. I will ask in dev@ list for help installing that plugin and for 
further review on this.
   
   
   ![Screen Shot 2021-12-22 at 17 44 
36](https://user-images.githubusercontent.com/74670721/147167235-ac165417-fed0-48db-ba25-113fa3e795ce.png)
   ![Screen Shot 2021-12-22 at 17 43 
33](https://user-images.githubusercontent.com/74670721/147167240-87ba8d2f-99c6-4eb6-9b98-7dece24c7f66.png)
   ![Screen Shot 2021-12-22 at 17 44 
07](https://user-images.githubusercontent.com/74670721/147167246-ecdee378-17ef-4566-a29a-06169cc51960.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to