timrobertson100 commented on a change in pull request #16336:
URL: https://github.com/apache/beam/pull/16336#discussion_r774432020
##########
File path:
sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/JdbcIOTest.java
##########
@@ -880,6 +881,72 @@ public void testGetPreparedStatementSetCaller() throws
Exception {
verify(psMocked, times(1)).setByte(11, Byte.parseByte("1", 2));
}
+ @Test
+ public void testGetPreparedStatementSetNullsCaller() throws Exception {
+
+ Schema schema =
+ Schema.builder()
+ // primitive
+ .addField("bigint_col", Schema.FieldType.INT64.withNullable(true))
Review comment:
Have we considered the behavior when setting null on fields that the
schema has a non-nullable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
