KonradJanica commented on a change in pull request #16183:
URL: https://github.com/apache/beam/pull/16183#discussion_r774766008
##########
File path:
playground/frontend/lib/modules/examples/repositories/example_client/grpc_example_client.dart
##########
@@ -73,7 +73,19 @@ class GrpcExampleClient implements ExampleClient {
.getPrecompiledObjectOutput(
_getExampleOutputRequestToGrpcRequest(request))
.then((response) =>
- OutputResponse(replaceIncorrectSymbols(response.output))),
+ OutputResponse(replaceIncorrectSymbols(response.output)))
+ .catchError((_) => OutputResponse('')),
+ );
+ }
+
+ @override
+ Future<OutputResponse> getExampleLogs(GetExampleRequestWrapper request) {
+ return _runSafely(
+ () => createClient(request.sdk)
+
.getPrecompiledObjectLogs(_getExampleLogRequestToGrpcRequest(request))
+ .then((response) =>
+ OutputResponse(replaceIncorrectSymbols(response.output)))
+ .catchError((_) => OutputResponse('')),
Review comment:
Perhaps this error should be logged for debugging purposes.
##########
File path:
playground/frontend/lib/modules/examples/repositories/example_client/grpc_example_client.dart
##########
@@ -73,7 +73,19 @@ class GrpcExampleClient implements ExampleClient {
.getPrecompiledObjectOutput(
_getExampleOutputRequestToGrpcRequest(request))
.then((response) =>
- OutputResponse(replaceIncorrectSymbols(response.output))),
+ OutputResponse(replaceIncorrectSymbols(response.output)))
+ .catchError((_) => OutputResponse('')),
Review comment:
Perhaps this error should be logged for debugging purposes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
