vitaly-ivanov commented on pull request #16284: URL: https://github.com/apache/beam/pull/16284#issuecomment-1000863741
@mosche thank you for your reasonable comments. > For instance, will every columnTypeName "uuid" always be represented as java.util.UUID across all DBs Until we have a specific JDBC type for UUID (ticket https://bugs.openjdk.java.net/browse/JDK-6798972), the behavior of JDBC drivers is not defined. But at least for Postgres and Vertica, the behavior looks the same. > Regardless of above, it may still be beneficial to add dedicated support for UUIDs (and a very limited set of other special types). However, a safer alternative to getColumnTypeName might be getColumnClassName if the driver supports it. Good point, I will rewrite to getColumnClassName. > Similar to above, but fall back to always representing OTHER types as strings using getObject(i).toString(). While more convenient and probably fine in most cases there might be issues. If i recall correctly this is how the Nifi Hive processor works. I like this option as looks like it is more suitable for most types and easier to use in comparison with bytes[]. In this case, we will have the support of JSON types automatically. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
