benWize commented on a change in pull request #16200:
URL: https://github.com/apache/beam/pull/16200#discussion_r776039814
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SqlOperators.java
##########
@@ -180,6 +176,43 @@
null,
new CastFunctionImpl());
+ public static SqlOperator createStringAggOperator(
+ ResolvedNodes.ResolvedFunctionCallBase aggregateFunctionCall) {
+ List<ResolvedNodes.ResolvedExpr> args =
aggregateFunctionCall.getArgumentList();
+ String inputType = args.get(0).getType().typeName();
+ Value delimiter = null;
+ if (args.size() == 2) {
+ delimiter = ((ResolvedNodes.ResolvedLiteral) args.get(1)).getValue();
+ }
+ switch (inputType) {
+ case "BYTES":
+ if (delimiter != null) {
+ return SqlOperators.createUdafOperator(
+ "string_agg",
+ x ->
SqlOperators.createTypeFactory().createSqlType(SqlTypeName.VARBINARY),
+ new UdafImpl<>(new
StringAgg.StringAggByte(delimiter.getBytesValue().toByteArray())));
+ }
+ return SqlOperators.createUdafOperator(
+ "string_agg",
+ x ->
SqlOperators.createTypeFactory().createSqlType(SqlTypeName.VARBINARY),
+ new UdafImpl<>(new StringAgg.StringAggByte()));
+ case "STRING":
+ if (delimiter != null) {
+ return SqlOperators.createUdafOperator(
+ "string_agg",
+ x ->
SqlOperators.createTypeFactory().createSqlType(SqlTypeName.VARCHAR),
+ new UdafImpl<>(new
StringAgg.StringAggString(delimiter.getStringValue())));
+ }
+ return SqlOperators.createUdafOperator(
+ "string_agg",
+ x ->
SqlOperators.createTypeFactory().createSqlType(SqlTypeName.VARCHAR),
+ new UdafImpl<>(new StringAgg.StringAggString()));
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
