emilymye commented on a change in pull request #16327:
URL: https://github.com/apache/beam/pull/16327#discussion_r776492654



##########
File path: sdks/python/scripts/generate_pydoc.sh
##########
@@ -117,6 +118,8 @@ master_doc = 'index'
 html_theme = 'sphinx_rtd_theme'
 html_theme_path = [sphinx_rtd_theme.get_html_theme_path()]
 project = 'Apache Beam'
+version = version.__version__

Review comment:
       I don't think it actually causes an issue right now since nothing is 
getting used later, it just makes me nervous when we have variables with the 
same names as packages. Could we alias the package as beam_version or something 
similar?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to