steveniemitz commented on a change in pull request #16229:
URL: https://github.com/apache/beam/pull/16229#discussion_r776509376
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##########
@@ -519,11 +523,16 @@ def __reduce__(self):
class DataflowApplicationClient(object):
+ _HASH_CHUNK_SIZE = 1024 * 8
+ _GCS_CACHE_PREFIX = "artifact_cache"
"""A Dataflow API client used by application code to create and query
jobs."""
- def __init__(self, options):
+ def __init__(self, options, root_staging_location=None):
Review comment:
it's used above
https://github.com/apache/beam/pull/16229/files#diff-d7e8ff5775f3fb328137483bd443e04d96caa92f3f68a188391f18a8e06075a0R574.
The runner mutates the staging location passed in to be unique per job, but
we need the root that the user actually passed in to derive the path for the
cache, otherwise the cache would be per-job, which would defeat the whole
purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
