roger-mike commented on a change in pull request #16256:
URL: https://github.com/apache/beam/pull/16256#discussion_r776843391
##########
File path: sdks/python/apache_beam/dataframe/frames_test.py
##########
@@ -1245,6 +1245,37 @@ def test_idxmax(self):
self._run_test(lambda s2: s2.idxmax(), s2)
self._run_test(lambda s2: s2.idxmax(skipna=False), s2)
+ def test_pipe(self):
+ def df_times(df, column, times):
+ df[column] = df[column] * times
+ return df
+
+ def s_times(s, times):
+ return s * times
+
+ df = pd.DataFrame({'A': [1, 2, 3], 'B': [4, 5, 6]}, index=[0, 1, 2])
+ s = pd.Series([1, 2, 3, 4, 5], index=[0, 1, 2, 3, 4])
+ # s2 = pd.Series([6, 7], index=[5, 6])
+
+ func_1 = df_times
+ func_2 = frames.DeferredDataFrame.sum
+ func_3 = frames.DeferredSeries.sum
+ func_4 = s_times
+ # func_5 = frames.DeferredSeries.append
+
+ self._run_inplace_test(lambda df: df.pipe(func_1, 'A', 2), df)
+ self._run_test(lambda df: df.pipe(func_2), df)
+ # type assert fails when axis=1
+ # self._run_test(lambda df: df.pipe(func_2, axis=1), df)
+ self._run_inplace_test(lambda df: df.pipe(func_1, 'A', 2).pipe(func_2), df)
+ self._run_test(lambda df: df.pipe(func_2).pipe(func_3), df)
+
+ self._run_test(lambda s: s.pipe(func_4, 2), s)
+ self._run_test(lambda s: s.pipe(func_3), s)
+ self._run_test(lambda s: s.pipe(func_4, 2).pipe(func_3), s)
+ # Can't append non-deferred series
+ # self._run_test(lambda s: s.pipe(func_5, s2).pipe(func_4, 2), s)
Review comment:
Does `s2` need to be wrapped as a DeferredSeries to make it work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
