vitaly-ivanov commented on a change in pull request #16284:
URL: https://github.com/apache/beam/pull/16284#discussion_r781192389



##########
File path: 
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/SchemaUtil.java
##########
@@ -105,7 +108,8 @@
     Schema.Field create(int index, ResultSetMetaData md) throws SQLException;
   }
 
-  private static BeamFieldConverter jdbcTypeToBeamFieldConverter(JDBCType 
jdbcType) {
+  private static BeamFieldConverter jdbcTypeToBeamFieldConverter(
+      JDBCType jdbcType, String columnClassName) {

Review comment:
       Agree. Done. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to