AydarZaynutdinov commented on a change in pull request #16469:
URL: https://github.com/apache/beam/pull/16469#discussion_r781387542
##########
File path: playground/backend/internal/code_processing/code_processing.go
##########
@@ -189,8 +189,13 @@ func Process(ctx context.Context, cacheService
cache.Cache, lc *fs_tool.LifeCycl
return
}
if !ok {
- if runOutput.Error != nil {
- runError.Write([]byte(runOutput.Error.Error()))
+ // If unit test has some error then error output is placed as
RunOutput
+ if isUnitTest {
+ output, err := GetProcessingOutput(ctx, cacheService,
pipelineId, cache.RunOutput, "")
+ if err == nil {
+ runError.Write([]byte(output))
+ }
Review comment:
This error occurs only if `GetProcessingOutput` method couldn't receive
the correct run output (there is no run output in the cache or it is no string
value). In this case, `GetProcessingOutput` method logs this error.
Receiving this error we do not need to send it to the other methods or to
log it, so we just will not use this error, because on the next lines we call
`processRunError` method after which the whole code processing will be finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
