AydarZaynutdinov commented on a change in pull request #16484:
URL: https://github.com/apache/beam/pull/16484#discussion_r782993729
##########
File path: playground/backend/internal/cloud_bucket/precompiled_objects.go
##########
@@ -173,6 +175,28 @@ func (cd *CloudStorage) GetPrecompiledObjects(ctx
context.Context, targetSdk pb.
return &precompiledObjects, nil
}
+// GetDefaultPrecompileObject returns the default precompiled object for the
sdk
+func (cd *CloudStorage) GetDefaultPrecompileObject(ctx context.Context,
targetSdk pb.Sdk, workingDir string) (*ObjectInfo, error) {
+ defaultExampleToSdk, err := getDefaultExamplesFromJson(workingDir)
Review comment:
Add error handling.
##########
File path: playground/backend/configs/DEFAULT_EXAMPLES.json
##########
@@ -0,0 +1,5 @@
+{
Review comment:
I am not sure that this file should be in `configs` folder. @KhaninArtur
@ilya-kozyrev what do you think?
##########
File path: playground/frontend/lib/api/v1/api.pbgrpc.dart
##########
@@ -17,13 +17,18 @@
*/
///
+// Generated code. Do not modify.
+// source: api/v1/api.proto
+//
+// @dart = 2.12
+// ignore_for_file:
annotate_overrides,camel_case_types,unnecessary_const,non_constant_identifier_names,library_prefixes,unused_import,unused_shown_name,return_of_invalid_type,unnecessary_this,prefer_final_fields
+
Review comment:
Remove this one.
##########
File path: playground/frontend/lib/api/v1/api.pbjson.dart
##########
@@ -17,8 +17,14 @@
*/
///
-import 'dart:convert' as $convert;
+// Generated code. Do not modify.
+// source: api/v1/api.proto
+//
+// @dart = 2.12
+// ignore_for_file:
annotate_overrides,camel_case_types,unnecessary_const,non_constant_identifier_names,library_prefixes,unused_import,unused_shown_name,return_of_invalid_type,unnecessary_this,prefer_final_fields,deprecated_member_use_from_same_package
+
Review comment:
Remove this one.
##########
File path: playground/backend/configs/DEFAULT_EXAMPLES.json
##########
@@ -0,0 +1,5 @@
+{
+ "SDK_JAVA": "SDK_JAVA/MinimalWordCount",
+ "SDK_GO": "SDK_GO/MinimalWordCount",
+ "SDK_PYTHON": "SDK_PYTHON/WordCountWithMetrics"
+}
Review comment:
Add an empty string.
##########
File path: playground/frontend/lib/api/v1/api.pb.dart
##########
@@ -17,6 +17,12 @@
*/
///
+// Generated code. Do not modify.
+// source: api/v1/api.proto
+//
+// @dart = 2.12
+// ignore_for_file:
annotate_overrides,camel_case_types,unnecessary_const,non_constant_identifier_names,library_prefixes,unused_import,unused_shown_name,return_of_invalid_type,unnecessary_this,prefer_final_fields
+
Review comment:
Remove this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
