pavel-avilov commented on a change in pull request #16482:
URL: https://github.com/apache/beam/pull/16482#discussion_r783041641
##########
File path: playground/backend/internal/preparators/java_preparators.go
##########
@@ -41,47 +39,85 @@ const (
publicClassNamePattern = "public class (.*?)
[{|implements(.*)]"
)
-// GetJavaPreparators returns preparation methods that should be applied to
Java code
-func GetJavaPreparators(filePath string) *[]Preparator {
+//JavaPreparersBuilder facet of PreparersBuilder
+type JavaPreparersBuilder struct {
+ PreparersBuilder
+}
+
+//JavaPreparers chains to type *PreparersBuilder and returns a
*JavaPreparersBuilder
+func (b *PreparersBuilder) JavaPreparers() *JavaPreparersBuilder {
+ return &JavaPreparersBuilder{*b}
+}
+
+//WithPublicClassRemover adds preparer to remove public class
+func (a *JavaPreparersBuilder) WithPublicClassRemover() *JavaPreparersBuilder {
Review comment:
```suggestion
func (jb *JavaPreparersBuilder) WithPublicClassRemover()
*JavaPreparersBuilder {
```
##########
File path: playground/backend/internal/preparators/python_preparators.go
##########
@@ -27,12 +27,30 @@ const (
)
// GetPythonPreparators returns preparation methods that should be applied to
Python code
-func GetPythonPreparators(filePath string) *[]Preparator {
+func GetPythonPreparators(builder *PreparersBuilder) {
+ builder.
+ PythonPreparers().
+ WithLogHandler()
+}
+
+//PythonPreparersBuilder facet of PreparersBuilder
+type PythonPreparersBuilder struct {
+ PreparersBuilder
+}
+
+//PythonPreparers chains to type *PreparersBuilder and returns a
*GoPreparersBuilder
+func (b *PreparersBuilder) PythonPreparers() *PythonPreparersBuilder {
+ return &PythonPreparersBuilder{*b}
+}
+
+//WithLogHandler adds code for logging
+func (a *PythonPreparersBuilder) WithLogHandler() *PythonPreparersBuilder {
Review comment:
```suggestion
func (pb *PythonPreparersBuilder) WithLogHandler() *PythonPreparersBuilder {
```
##########
File path: playground/backend/internal/preparators/java_preparators.go
##########
@@ -41,47 +39,85 @@ const (
publicClassNamePattern = "public class (.*?)
[{|implements(.*)]"
)
-// GetJavaPreparators returns preparation methods that should be applied to
Java code
-func GetJavaPreparators(filePath string) *[]Preparator {
+//JavaPreparersBuilder facet of PreparersBuilder
+type JavaPreparersBuilder struct {
+ PreparersBuilder
+}
+
+//JavaPreparers chains to type *PreparersBuilder and returns a
*JavaPreparersBuilder
+func (b *PreparersBuilder) JavaPreparers() *JavaPreparersBuilder {
+ return &JavaPreparersBuilder{*b}
+}
+
+//WithPublicClassRemover adds preparer to remove public class
+func (a *JavaPreparersBuilder) WithPublicClassRemover() *JavaPreparersBuilder {
removePublicClassPreparator := Preparator{
Prepare: removePublicClassModifier,
- Args: []interface{}{filePath,
classWithPublicModifierPattern, classWithoutPublicModifierPattern},
+ Args: []interface{}{a.filePath,
classWithPublicModifierPattern, classWithoutPublicModifierPattern},
}
+ a.AddPreparer(removePublicClassPreparator)
+ return a
+}
+
+//WithPackageChanger adds preparer to change package
+func (a *JavaPreparersBuilder) WithPackageChanger() *JavaPreparersBuilder {
changePackagePreparator := Preparator{
Prepare: changePackage,
- Args: []interface{}{filePath, packagePattern,
importStringPattern},
+ Args: []interface{}{a.filePath, packagePattern,
importStringPattern},
}
+ a.AddPreparer(changePackagePreparator)
+ return a
+}
+
+//WithPackageRemover adds preparer to remove package
+func (a *JavaPreparersBuilder) WithPackageRemover() *JavaPreparersBuilder {
Review comment:
ditto
##########
File path: playground/backend/internal/preparators/java_preparators.go
##########
@@ -41,47 +39,85 @@ const (
publicClassNamePattern = "public class (.*?)
[{|implements(.*)]"
)
-// GetJavaPreparators returns preparation methods that should be applied to
Java code
-func GetJavaPreparators(filePath string) *[]Preparator {
+//JavaPreparersBuilder facet of PreparersBuilder
+type JavaPreparersBuilder struct {
+ PreparersBuilder
+}
+
+//JavaPreparers chains to type *PreparersBuilder and returns a
*JavaPreparersBuilder
+func (b *PreparersBuilder) JavaPreparers() *JavaPreparersBuilder {
+ return &JavaPreparersBuilder{*b}
+}
+
+//WithPublicClassRemover adds preparer to remove public class
+func (a *JavaPreparersBuilder) WithPublicClassRemover() *JavaPreparersBuilder {
removePublicClassPreparator := Preparator{
Prepare: removePublicClassModifier,
- Args: []interface{}{filePath,
classWithPublicModifierPattern, classWithoutPublicModifierPattern},
+ Args: []interface{}{a.filePath,
classWithPublicModifierPattern, classWithoutPublicModifierPattern},
}
+ a.AddPreparer(removePublicClassPreparator)
+ return a
+}
+
+//WithPackageChanger adds preparer to change package
+func (a *JavaPreparersBuilder) WithPackageChanger() *JavaPreparersBuilder {
changePackagePreparator := Preparator{
Prepare: changePackage,
- Args: []interface{}{filePath, packagePattern,
importStringPattern},
+ Args: []interface{}{a.filePath, packagePattern,
importStringPattern},
}
+ a.AddPreparer(changePackagePreparator)
+ return a
+}
+
+//WithPackageRemover adds preparer to remove package
+func (a *JavaPreparersBuilder) WithPackageRemover() *JavaPreparersBuilder {
removePackagePreparator := Preparator{
Prepare: removePackage,
- Args: []interface{}{filePath, packagePattern,
newLinePattern},
+ Args: []interface{}{a.filePath, packagePattern,
newLinePattern},
}
+ a.AddPreparer(removePackagePreparator)
+ return a
+}
+
+//WithFileNameChanger adds preparer to remove package
+func (a *JavaPreparersBuilder) WithFileNameChanger() *JavaPreparersBuilder {
Review comment:
ditto
##########
File path: playground/backend/internal/preparators/java_preparators.go
##########
@@ -41,47 +39,85 @@ const (
publicClassNamePattern = "public class (.*?)
[{|implements(.*)]"
)
-// GetJavaPreparators returns preparation methods that should be applied to
Java code
-func GetJavaPreparators(filePath string) *[]Preparator {
+//JavaPreparersBuilder facet of PreparersBuilder
+type JavaPreparersBuilder struct {
+ PreparersBuilder
+}
+
+//JavaPreparers chains to type *PreparersBuilder and returns a
*JavaPreparersBuilder
+func (b *PreparersBuilder) JavaPreparers() *JavaPreparersBuilder {
+ return &JavaPreparersBuilder{*b}
+}
+
+//WithPublicClassRemover adds preparer to remove public class
+func (a *JavaPreparersBuilder) WithPublicClassRemover() *JavaPreparersBuilder {
removePublicClassPreparator := Preparator{
Prepare: removePublicClassModifier,
- Args: []interface{}{filePath,
classWithPublicModifierPattern, classWithoutPublicModifierPattern},
+ Args: []interface{}{a.filePath,
classWithPublicModifierPattern, classWithoutPublicModifierPattern},
}
+ a.AddPreparer(removePublicClassPreparator)
+ return a
+}
+
+//WithPackageChanger adds preparer to change package
+func (a *JavaPreparersBuilder) WithPackageChanger() *JavaPreparersBuilder {
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
