ibzib commented on pull request #16200:
URL: https://github.com/apache/beam/pull/16200#issuecomment-1011399863
I tried compliance testing from your second-most recent commit
(5ea6102266e0f477e8cc4b9f0efb2831df72610b) and there's at least one more
failing test. I think we should allow ResolvedParameter as the 2nd+ argument.
Name:
aggregation_queries_test:aggregation_string_agg_error_1_null_string_param
```sql
SELECT string_agg("s", @separator) FROM (SELECT 1)
```
Parameters:
`@separator = String(NULL)`
```
java.lang.ClassCastException: class
com.google.zetasql.resolvedast.ResolvedNodes$ResolvedParameter cannot be cast
to class com.google.zetasql.resolvedast.ResolvedNodes$ResolvedLiteral
(com.google.zetasql.resolvedast.ResolvedNodes$ResolvedParameter and
com.google.zetasql.resolvedast.ResolvedNodes$ResolvedLiteral are in unnamed
module of loader 'app')
at
org.apache.beam.sdk.extensions.sql.zetasql.translation.SqlOperators.createStringAggOperator(SqlOperators.java:186)
at
org.apache.beam.sdk.extensions.sql.zetasql.translation.SqlOperatorMappingTable.create(SqlOperatorMappingTable.java:124)
at
org.apache.beam.sdk.extensions.sql.zetasql.translation.AggregateScanConverter.convertAggCall(AggregateScanConverter.java:238)
at
org.apache.beam.sdk.extensions.sql.zetasql.translation.AggregateScanConverter.convert(AggregateScanConverter.java:99)
at
org.apache.beam.sdk.extensions.sql.zetasql.translation.AggregateScanConverter.convert(AggregateScanConverter.java:55)
at
org.apache.beam.sdk.extensions.sql.zetasql.translation.QueryStatementConverter.convertNode(QueryStatementConverter.java:102)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
