lostluck commented on a change in pull request #16487:
URL: https://github.com/apache/beam/pull/16487#discussion_r783565635
##########
File path: sdks/go/pkg/beam/core/runtime/xlangx/expansionx/process.go
##########
@@ -60,11 +63,24 @@ func (e *ExpansionServiceRunner) String() string {
}
// Endpoint returns the formatted endpoint the ExpansionServiceRunner is set
to start the expansion
-// service on.
+// service on.
func (e *ExpansionServiceRunner) Endpoint() string {
return "localhost:" + e.servicePort
}
+func (e *ExpansionServiceRunner) pingEndpoint(timeout time.Duration) error {
Review comment:
Notionally this will mean things take a bit longer since we're
connecting twice (here, and actual use), but It's probably fine until we
determine if it's problematic or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
