ibzib commented on a change in pull request #16380:
URL: https://github.com/apache/beam/pull/16380#discussion_r784194971



##########
File path: 
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamComplexTypeTest.java
##########
@@ -367,21 +370,21 @@ public void testNullInnerRow() {
         pipeline
             .apply(Create.of(row))
             .setRowSchema(nullableNestedRowWithArraySchema)
-            .apply(
-                SqlTransform.query(
-                    "select PCOLLECTION.field3.inner_row_field.string_field as 
string_field, PCOLLECTION.field3.array_field[1].long_field as long_field from 
PCOLLECTION"));
+            .apply(SqlTransform.query("select field1 is null, field3 is null 
from PCOLLECTION"));
 
-    PAssert.that(outputRow)
-        .containsInAnyOrder(
-            Row.withSchema(
-                    Schema.builder()
-                        .addNullableField("string_field", FieldType.STRING)
-                        .addInt64Field("long_field")
-                        .build())
-                .addValues(null, 1000L)
-                .build());
+    outputRow.apply("output", ParDo.of(new SimplePardo<Row, 
Integer>())).setCoder(VarIntCoder.of());
 
-    pipeline.run().waitUntilFinish(Duration.standardMinutes(2));
+    //    PAssert.that(outputRow)

Review comment:
       Was this change intentional?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to