benWize commented on pull request #16200:
URL: https://github.com/apache/beam/pull/16200#issuecomment-1012661753
I tried adding a new test with the query `SELECT string_agg("s",
@separator) FROM (SELECT 1)` and It failed in
https://github.com/apache/beam/blob/f45b17242ef125e1ac0f303cc231e9bab614c207/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SqlOperators.java#L186
I tried adding a new case for ResolvedParameter but I couldn't get the value
for delimiter there, it is undefined at that point, I'm not sure how I should
handle that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
